Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#74 limit maximal resolution of videos #80

Merged
merged 3 commits into from
Jan 29, 2020
Merged

#74 limit maximal resolution of videos #80

merged 3 commits into from
Jan 29, 2020

Conversation

Rpsl
Copy link
Contributor

@Rpsl Rpsl commented Jan 29, 2020

I tried to solve the problem that I wrote in the issue #74

I did make refactoring of code about generate arguments for the youtube-dl and added new optional param in config.

what do you think?

Rpsl and others added 2 commits January 29, 2020 13:35
[+] add optional param "max_height" to config for limit of maximal resolution of video
[+] test
Copy link
Owner

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Mostly LGTM, just a few minor comments.

pkg/ytdl/options_video.go Outdated Show resolved Hide resolved
pkg/model/feed.go Outdated Show resolved Hide resolved
@mxpv mxpv merged commit 4fb66ae into mxpv:master Jan 29, 2020
Rpsl added a commit to Rpsl/podsync that referenced this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants